ebourg / jsign

Java implementation of Microsoft Authenticode for signing Windows executables, installers & scripts
https://ebourg.github.io/jsign
Apache License 2.0
250 stars 107 forks source link

Fixes #148 - log4j stderr message about not finding a logging implementation when using jsign CLI #206

Closed davoustp closed 3 months ago

davoustp commented 4 months ago

This fix makes the suggestion from https://github.com/ebourg/jsign/issues/148#issuecomment-1555797023 permanent, by leveraging the log4j2 properties mechanism (instead of relying onto users to do it themselves, struggling with passing Java props to an executable jar).

Reference:

ebourg commented 4 months ago

Merci ! I guess the log4j2.loggerContextFactory property can be removed from jsign.sh and jsign.cmd too.

davoustp commented 4 months ago

Merci ! I guess the log4j2.loggerContextFactory property can be removed from jsign.sh and jsign.cmd too.

De rien! ;-) I did commit this small change as well (these files went under the radar).