The msi signing failed - Githubissues

ebourg / jsign

Java implementation of Microsoft Authenticode for signing Windows executables, installers & scripts

https://ebourg.github.io/jsign

Apache License 2.0

259 stars 108 forks source link

Closed borjafg closed 4 years ago

borjafg commented 4 years ago

I tried to sign a msi file but the ant task failed. I did the same with your minimal-msi file and it worked.

The configuration is the same and the msi I tried to sign was generated with "advance installer".

========================================

Buildfile: build.xml [jsign] Adding Authenticode signature to my_msi.msi

BUILD FAILED Couldn't sign my_msi.msi

Total time: 1 second

ebourg commented 4 years ago

Thank you for the report. Could you send a minimal installer built with this tool to ebourg@apache.org please? I'll give it a look.

borjafg commented 4 years ago

I tried with a simple msi that contains only one file and it worked.

I don't understand why it fails with the other msi. The other msi size is 80Mb.

ebourg commented 4 years ago

Do you get a stacktrace when running Ant in debug mode ?

borjafg commented 4 years ago

No, but this Monday I'll try to get the stacktrace by debugging the source code of the library. I don't have the ".msi" here to replicate the error.

In a future version of the library, you should add an optional parameter to print the full stacktrace.

ebourg commented 4 years ago

I think I've fixed the issue, could you give it a try?

borjafg commented 4 years ago

I will try it this Monday. Right now I don't have the ".msi" that gave me the error.

Thanks.

borjafg commented 4 years ago

I tried it again. The bug was fixed with your commit.

Can you make a release or send me a packaged version of the library? I tried to generate the jar myself but the signing failed with that jar.

ebourg commented 4 years ago

Thank you for confirming. I'll prepare a new release by next week.

ebourg commented 4 years ago

@borjafg the new release is out