ebourg / jsign

Java implementation of Microsoft Authenticode for signing Windows executables, installers & scripts
https://ebourg.github.io/jsign
Apache License 2.0
250 stars 107 forks source link

Force digest encryption algorithm to "RSA" instead of "sha256RSA" (#95) #96

Closed yaegor closed 2 years ago

yaegor commented 2 years ago

Simple solution forcing RSA for the specific case of "sha256RSA" algorythm (#95). It might be appropriate to force RSA for all algorithms or add an option instead.

ebourg commented 2 years ago

Thank you for the patch but this addresses only the sha256RSA case, I guess there is a similar issue with sha384RSA and sha512RSA. If I read correctly the DefaultCMSSignatureEncryptionAlgorithmFinder implementation the SHA-1 case is already handled.