ebov / space-time

Analysis of EBOV genome sequence from Guinea, Sierra Leone and Liberia from 2014-2016
Creative Commons Attribution Share Alike 4.0 International
58 stars 19 forks source link

Some missing details #1

Open sdwfrost opened 7 years ago

sdwfrost commented 7 years ago

Hi @evogytis @rambaut @plemey @trvrb @msuchard

A few things in the repository that I couldn't find in the biorXiv paper:

Don't mean to be a pain, but I'd much rather use a common resource rather than try to reproduce with subtly different results.

rambaut commented 7 years ago

Hi Simon,

Now the paper is out the way, we are working on updating the github READMEs with as much detail as possible. Gytis - when you have a minute could you put some details about the points below? I will describe the date imputing.

On another note, the full output of BEAST (2 independent runs with trees etc) have a DOI: http://dx.doi.org/10.7488/ds/1711 http://dx.doi.org/10.7488/ds/1711

Andrew

On 16 Feb 2017, at 11:20, Simon Frost notifications@github.com wrote:

Hi @evogytis https://github.com/evogytis @rambaut https://github.com/rambaut @plemey https://github.com/plemey @trvrb https://github.com/trvrb @msuchard https://github.com/msuchard A few things in the repository that I couldn't find in the biorXiv paper:

How was the ML tree reconstructed? Which putative ADAR edited sites/sequences were masked? Are the data in Data/ the masked or unmasked data? How were missing dates imputed? Any update on the missing accession numbers? Don't mean to be a pain, but I'd much rather use a common resource rather than try to reproduce with subtly different results.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/ebov/space-time/issues/1, or mute the thread https://github.com/notifications/unsubscribe-auth/AAp5RQL_eMT4C1neKTV2ZpA2RqaFs97Dks5rdDEGgaJpZM4MC47g.

evogytis commented 7 years ago

Hey @sdwfrost,

Responses in order:

sdwfrost commented 7 years ago

Thanks @evogytis @rambaut

evogytis commented 7 years ago

Hey @sdwfrost

rambaut commented 7 years ago

I have a command-line script that bats back and forth between phyml (to create an initial tree using NJ), RAXML to search topologies, and back to Phyml to improve branch lengths. Am re-running on the 1610 data here and will upload all in a couple of days.

rambaut commented 7 years ago

Missing accession numbers are from the Quick et al MinION sequencing. This is because although the raw data were on ENA, the consensuses were simply on Nick's github. These have recently been deposited in genbank so will endeavour to match accession to sequence in the tables. Creating Issue...

BEAST-Community commented 6 years ago

Very nice work! @rambaut @evogytis @msuchard @plemey . @rambaut, could you tell me how to how to back and forth between phyml and RAxML to get a better tree, thank you.

evogytis commented 6 years ago

@BEAST-Community the script is now in the repo with 67a36db3994c070ba9b55499fdfd2c0e8b651412.