ebpf-io / ebpf.io-website

ebpf.io Website
https://ebpf.io
Creative Commons Attribution 4.0 International
113 stars 117 forks source link

Recommendation to adopt neutral language tags (zh-Hans and zh-Hant) for chinese localization #615

Closed blueswen closed 2 months ago

blueswen commented 3 months ago

What Needs To Be Fixed?

The current locale identifiers on the eBPF website use zh-cn for Simplified Chinese and tw-cn for Traditional Chinese, along with the China flag in the UI. This setup could unintentionally suggest a limited geographical use of the Chinese language, which is spoken and written in many regions around the world beyond China. Additionally, this could inadvertently introduce a degree of political bias, which is likely unintentional but worth addressing to maintain neutrality.

Page(s) Affected

I18n drop-down menu on the menu bar.

Suggested Improvement

It would be beneficial to switch to a more internationally recognized and neutral standard for language identifiers, aligning with RFC 5646. I suggest using zh-Hans for Simplified Chinese and zh-Hant for Traditional Chinese.

xmulligan commented 3 months ago

Thanks for pointing this out. I think the suggestion for zh-Hans and zh-Hant make sense. Do you have a different idea for the flag?

Also would you be willing to submit a PR for this change?

blueswen commented 3 months ago

I have submitted a draft PR for this issue, but I don't have any idea about the flag. Is it possible not to put a flag?

xmulligan commented 3 months ago

Thank you for the PR! I would prefer to put a flag because it can be easier to find the language you are looking for if you don't understand anything on the page. Flags are easy way to find a language so we generally use the flag of where the language originated from.

xmulligan commented 3 months ago

I'll also be on vacation to next week so sorry if there is a delay to get back to you after this.

blueswen commented 3 months ago

Got it. I added the Taiwan flag for zh-hant.

xmulligan commented 2 months ago

I think you made a good point about the flags so we will remove them and just stick with the languages. I'll merge the PR as is then go about removing the flags.

blueswen commented 2 months ago

Thanks for the merging. This issue can be closed.