search

ebranlard / pyDatView

A crossplatform GUI to plot tabulated data from files (e.g. CSV, Excel, OpenFAST, HAWC2, Flex...), or python pandas dataframes
MIT License
107 stars 41 forks source link

def multiInterp for text variables #151

Closed SimonHH closed 1 year ago

SimonHH commented 1 year ago

Hi,

When merging two tables both containing a variable 'filename' (consisting of text values) def multiInterp gives an error as text values can not be interpolated. multiInterp is used as OnMergeTabs detects 2 common columns (index and filename).

Could we detect text variables and if detected just concatenation the dataframe without the interpolation? Otherwise we could try to interpolate and if that fails (as in this case) concatenate the dataframes in def mergeTabs.

Best regards, Simon

ebranlard commented 1 year ago

Hi @SimonHH The merging feature definitely needs some ironing. Ultimately, we would need some kind of popup menu where the user could chose some merging method and which column to use to merge. The approach you suggest sounds fair. Feel free to try to implement it to make the merging more robust.

From the back of my head, I think there is a behavior that I don't really like with merging, I can't remember which one. Something like the index column gets repeated (I implemented the "merging" feature at the time where the "index" column was a hidden column. Now the "index" column is a true column of the dataframe. ).

Anyway, feel free to adapt that feature in what makes sense. If we think that it would start to make sense to add a popup window for some parameters we could do something similar to the "add column" popup.

Cheers!