search

ebrehault / resurrectio

CasperJS test recorder Chrome extension
GNU General Public License v2.0
721 stars 106 forks source link

Replace function does not replace all occurences #7

Closed altryne closed 10 years ago

altryne commented 10 years ago

Replace function did not replace all classes, script failed on clicking dom items with more then 2 classes. This adds replace with a regex replace with a global flag to replace all occurrences, as well as trimming it so cases lik class=" btn" won't break the code

altryne commented 10 years ago

hey @ebrehault thanx for merging, when are you going to update the chrome extension? :)

ebrehault commented 10 years ago

I just did :) (you are lucky, I am about to leave for vacations)

thanks for contributing

altryne commented 10 years ago

Sure thing! Love this! Tired of writing them manually Have fun on vacation! — Sent from Mailbox for iPhone

On Thu, Aug 1, 2013 at 6:43 PM, Eric BREHAULT notifications@github.com wrote:

I just did :) (you are lucky, I am about to leave for vacations)

thanks for contributing

Reply to this email directly or view it on GitHub: https://github.com/ebrehault/resurrectio/pull/7#issuecomment-21945079