search

ebrelsford / Leaflet.loading

A simple loading control for Leaflet
MIT License
143 stars 49 forks source link

Note about warning in dev tools #18

Closed robbiet480 closed 10 years ago

robbiet480 commented 10 years ago

@ebrelsford Just realized that the suggested fix works, but only if you aren't including Leaflet.loading via Bower. What are your thoughts if, instead, the line in question background: url(); is commented by default, and a user needs to uncomment it to use images? I think that's reasonable, since they need to change the URL anyway.

ebrelsford commented 10 years ago

These are good points. I'd be down to just comment out the line. That seems like the least obstructive way and doesn't require more documentation. I can do this later today.

robbiet480 commented 10 years ago

@ebrelsford Had a free second, so I did it for you! If you could accept, tag and bump the bower.json version, that would be great.