search

ebrelsford / Leaflet.loading

A simple loading control for Leaflet
MIT License
143 stars 49 forks source link

Removable control #5

Closed nickiaconis closed 11 years ago

nickiaconis commented 11 years ago

It follows from the ability to add a control to the map that one should also be able to remove that control. This enables the ability to remove the loading control.

The code follows L.Control.ZoomControl closely, but this means map.loadingControl is not guaranteed to exist. That's okay since the control always references itself directly (rather than through its instance assumed to be attached to the map).

ebrelsford commented 11 years ago

Thanks again for this, and for your patience with me as I handle my first few PRs.

You might be interested in 9b0ccf9 (keeps contexts for off() the same--Leaflet wasn't removing the handlers for me without this!) and cfee6b8 (avoids wiping out the zoomControl container).

nickiaconis commented 11 years ago

It's been a pleasure. This has been my first contribution to someone else's project, and I'm still getting the hang of using GitHub, so thanks for your patience as well.