search

ebroecker / canmatrix

Converting Can (Controller Area Network) Database Formats .arxml .dbc .dbf .kcd ...
BSD 2-Clause "Simplified" License
926 stars 400 forks source link

Support for SECURED-I-PDU #382

Closed stefan325 closed 5 years ago

stefan325 commented 5 years ago

Hello ebroecker,

thanks for canmatrix. I have been using the examples/convert.yp script with a CAN FD Armxl (I am using your branch iss363 as described in issue https://github.com/ebroecker/canmatrix/issues/363), and it mostly works very well. However, it looks that there presently is no support for SECURED-I-PDUs. Console output is "INFO - arxml - found secured pdu - no signal extraction possible: [...]".

I have a got an ARXML file with SECURED-I-PDUs and I am interested in that feature. Have you ever looked into SECURED-I-PDUs? It looks like the basic functionality could be added without too much trouble. In the Pdus top-level package, there is a SECURED-I-PDU Element instead of the "normal" I-SIGNAL-I-PDU element. This elemnt points to a PAYLOAD-REF in the CommunicationClusters top-level package. The PAYLOAD-REF in turn, points to a regular I-SIGNAL-I-PDU, which contains the I-SIGNAL-I-PDU mappings. What do you think?

image

ebroecker commented 5 years ago

Hello @stefan325

Thanks for your analysis. I'd never looked into these 'secured' pdus.

Gonna start implementing...

ebroecker commented 5 years ago

... it seems to be easy to fix, could you try branch "iss382" ?

stefan325 commented 5 years ago

Hello @ebroecker,

I am impressed. It works, thank you!

Best,

Stefan

ebroecker commented 5 years ago

@stefan325

Thanks for your quick feedback. Merged this small change into branch "iss363", will go mainline in the near future