ebroecker / canmatrix

Converting Can (Controller Area Network) Database Formats .arxml .dbc .dbf .kcd ...
BSD 2-Clause "Simplified" License
933 stars 401 forks source link

arxml: Only get min/max of the INTERNAL-CONSTR #779

Closed pempem98 closed 7 months ago

pempem98 commented 8 months ago

Under the tag DATA-CONSTR could have PHYS-CONSTRS and INTERNAL-CONSTRS in one DATA-CONSTR-RULE and could be have more than one tag DATA-CONSTR-RULE, with current logic, we only use the LOWER-LIMIT and UPPER-LIMIT of the tag INTERNAL-CONSTRS so I modify a little to make it get the lowest internal constr value and biggest internal constr value to lower/upper variables

pempem98 commented 8 months ago

This may fix the issue https://github.com/ebroecker/canmatrix/issues/740 But still need someone do the verification

ebroecker commented 7 months ago

Hi @pempem98, I'll merge this one. If you have further improvements, just create a new pr!