search

ebroecker / canmatrix

Converting Can (Controller Area Network) Database Formats .arxml .dbc .dbf .kcd ...
BSD 2-Clause "Simplified" License
933 stars 401 forks source link

Buttons for Folding/Unfolding Messages in Excel desappear at development branch compared to master #780

Closed djdesant closed 6 months ago

djdesant commented 7 months ago

master development

The file is converted from dbc to xlsx format. The buttons 1/2 for folding/unfolding are very useful feature for grouping the message view. It would be nice to have it in the development branch too.

ebroecker commented 7 months ago

Hi @djdesant

Thanks for reporting this Bug! Gonna have a Look on it

djdesant commented 7 months ago

Thanks for quick response @ebroecker, i guess the replacement of xlsxwriter by openpyxl should be the cause of this issue.

ebroecker commented 7 months ago

hi @djdesant

yes indeed, the old code for folding is even in the comments :-) But I totally forgot about it

ebroecker commented 7 months ago

should be fixed in branch issue780_fold_xlsx

You should be able to test:

pip install git+https://github.com/ebroecker/canmatrix/tree/issue780_fold_xlsx

djdesant commented 7 months ago

should be fixed in branch issue780_fold_xlsx

You should be able to test:

pip install git+https://github.com/ebroecker/canmatrix/tree/issue780_fold_xlsx

I have tested the bugfix of #780 successfully. The right package install syntax for me was: pip install git+https://github.com/ebroecker/canmatrix.git@issue780_fold_xlsx

Fixing of #778 is still needed for continuing the proper work on DBC-converting.

Thanks in advance.

djdesant commented 7 months ago

@ebroecker, when are you planning to merge the current branch into master ?