search

ebruneton / precomputed_atmospheric_scattering

This project provides a new implementation of our EGSR 2008 paper "Precomputed Atmospheric Scattering".
BSD 3-Clause "New" or "Revised" License
922 stars 121 forks source link

Added cmake build script for windows #2

Closed cperthuis closed 7 years ago

cperthuis commented 7 years ago

Hi,

If you're interested, here's a set of files which adds support for Visual Studio on windows. It can be more convenient for video game developers.

Great work on the sample!

Cedric

ebruneton commented 7 years ago

Thanks for your contribution. I'm not familiar with Windows development, but wouldn't a Visual Studio project file be more useful than a cmake script? Also, I would prefer a script to download the dependencies rather than the dependencies themselves.

cperthuis commented 7 years ago

I would argue that the cmake script is more useful than a visual project. The visual studio project is one click away with a cmake script, and it makes changing settings, dependencies locations, architecture target or visual studio version easy.

Hum, I didn't mean to include the dependencies in the pull request. I didn't know that the pull request didn't use the revision but only the branch. I kept submitting to my branch after I submitted the pull request, and that's why they showed up for you. I probably need to create another branch without those files. As for a download script, it might be difficult to do with simple batch commands. I'll have a look if I find some time.

ebruneton commented 7 years ago

Some changes to the build have been made in https://github.com/ebruneton/precomputed_atmospheric_scattering/pull/14. GLEW is no longer used, and some source files have been added. Could you update the build script for Windows (I don't have the necessary tools to do this myself)?

cperthuis commented 7 years ago

Sure, I submitted a PR for it here: https://github.com/ebruneton/precomputed_atmospheric_scattering/pull/18