Online demo does not work

ebruneton / precomputed_atmospheric_scattering

This project provides a new implementation of our EGSR 2008 paper "Precomputed Atmospheric Scattering".

BSD 3-Clause "New" or "Revised" License

908 stars 120 forks source link

Online demo does not work #39

Closed warmist closed 4 years ago

warmist commented 4 years ago

I'm using Chrome 83.0.4103.116 on win 7 with AMD Radeon R9 200. Chrome console is filled (256 times) with [.WebGL-000000000C0547A0] GL_INVALID_OPERATION: Two textures of different types use the same sampler location.

script526 commented 4 years ago

Doesn't work for me as well.

ebruneton commented 4 years ago

Unfortunately I don't have the necessary hardware & OS to reproduce this (the demo works fine for me). I committed a change which I guess (from the console log) could fix this, but I'm not sure. The online demo has been updated with this change.

script526 commented 4 years ago

Now it's working. Win 10, Chrome, GTX 1080. Thank you. Looks freaking good. Any helpers how to implement it in Unity? (C# and HLSL)

warmist commented 4 years ago

Just checked and it's fixed. Thank you!

ebruneton commented 4 years ago

Thanks! A Unity port is available here: https://github.com/Scrawk/Brunetons-Improved-Atmospheric-Scattering

script526 commented 4 years ago

Thank you very much. Do you think it is going to be working in HDRP?