search

ebryn / ember-model

A lightweight model library for Ember.js
MIT License
524 stars 159 forks source link

Replace `grunt develop` and `grunt test` with Testem #471

Closed patocallaghan closed 6 years ago

patocallaghan commented 6 years ago

Replaces grunt-contrib-qunit with grunt-testem-mincer. This allows us to drop support for PhantomJS and other dependencies like grunt-contrib-connect and grunt-contrib-watch.

It's worth noting I needed to use my own modified fork of grunt-testem-mincer as the version of testem it installed is pre 1.0 and this caused issues on CI. It doesn't support sending flags to the test browser so we couldn't run Chrome on Travis CI without the sandbox. This meant Travis CI would fail with permission errors. Forking grunt-testem-mincer and updating Testem unblocks us as it gets tests passing on CI for the gj/2.12 branch (https://travis-ci.org/ebryn/ember-model/builds/3421447940). I have a PR open to update the Testem version in grunt-testem-mincer https://github.com/inossidabile/grunt-testem-mincer/pull/39.

/cc @GavinJoyce

GavinJoyce commented 6 years ago
screen shot 2018-02-16 at 08 46 12
GavinJoyce commented 6 years ago

Merging now so that we have logs on CI, tracking a further upgrade to node in https://github.com/ebryn/ember-model/issues/472