search

ebsco / edna

A custom CSS framework
Other
1 stars 8 forks source link

readding the % formatting. csslint did not like rgba in the filter. #125

Closed pivnickm closed 9 years ago

pivnickm commented 9 years ago

It appears that it was the css escaping, e() that was messing the mixin in ie. This should fix the Edna build

gjjones commented 9 years ago

I'm not a fan of committing the work separately like this. Is there a particular reason we aren't doing a PR into #release from a hotfix branch that then gets PR'd down to #develop?

That said, there are worse things in the world than making each commit like we are. I could be down with it if you really need this to get through into the codebase.

gjjones commented 9 years ago

Why do you talk about removing the "e()" when it doesn't appear to be part of your modification?

pivnickm commented 9 years ago

@gjjones the removal of e() was part of the original PR. the filter was wrapped in e(%()), I removed both originally, but the %() was actually still needed.

And I can totally do the Release -> Dev merge instead. Not really a huge deal, I suppose. But the build is broken.

gjjones commented 9 years ago

We mine as well at least push this through since merging it fixes the build. We can easily iron out the details later for the #develop one.