search

ebsco / edna

A custom CSS framework
Other
1 stars 9 forks source link

Remove coloring from bold class in release branch #178

Closed amyh closed 8 years ago

gjjones commented 8 years ago

Safe to assume this is for 15.4?

wylie commented 8 years ago

Yep, it's going into release

wylie commented 8 years ago

This color might not need to be in the strong declaration. I'm not a fan of using the .bold class in the markup. Can we use another strong tag and remove the .bold class? It's silly to use a class that markup can do better.

<p class="txt" data-auto="buzz-paragraph">
    You have viewed 
    <strong>1</strong>
    of <strong>10</strong>
    Free Topics. Sign up for a 
    <a class="bold" href="http://auth-qa.dynamed.com/webauth/login.aspx?trial-link">FREE 90 Day Trial</a>
    now. Already a subscriber? 
    <a class="bold" href="http://auth-qa.dynamed.com/webauth/login.aspx">Log In</a>.
</p>
gjjones commented 8 years ago

I'm going to agree from the consistency standpoint unless there's a very good reason why two things right next to each other would be using different styling methods.

amyh commented 8 years ago

I agree that it's better to be consistent. I still think the .bold class is preferable to <strong> in this context because I wouldn't say those phrases more loudly than the text around them, but maybe that's not my call.

wylie commented 8 years ago

Then it sounds like this is a perfect case for a <b> element.

In fact every use of the .bold class should be changed to a <b> element.

Do not confuse the <b> element with the <strong>, <em>, or <mark> elements. The <strong> element represents text of certain importance, <em> puts some emphasis on the text and the <mark> element represents text of certain relevance. The <b> element doesn't convey such special semantic information; use it only when no others fit.

https://developer.mozilla.org/en-US/docs/Web/HTML/Element/b

amyh commented 8 years ago

OK, so if I change all the tags to <b>, can we remove the color in the release branch?

wylie commented 8 years ago

So long as that doesn't cause any issues anywhere, this color has been in here for a while so some things might be looking for the color specified. Have you checked everything for uses of the .bold class and <strong> or <b> elements?

Never mind, will be merging in.