ebsco / edna

A custom CSS framework
Other
1 stars 8 forks source link

Add defaults for new variables #196

Closed amyh closed 8 years ago

amyh commented 8 years ago

These are needed for the header-bg-img class. They need to be defined for all interfaces.

leachryanb commented 8 years ago

Looks good

gjjones commented 8 years ago

Header isn't an edna thing, it's a buzz widget. This is not a good place for this work to exist unless the header is being brought to edna.

amyh commented 8 years ago

The _variables.less file has a section for widgets, which is where I added the variables. I think this is the correct place for these values to be defined.

wylie commented 8 years ago

@gjjones is correct, this doesn't belong in Edna. The headers are a Buzz widget.