search

ebsco / edna

A custom CSS framework
Other
1 stars 9 forks source link

Blank slate #210

Closed gjjones closed 8 years ago

gjjones commented 8 years ago

This is not to say none of that stuff is useful. We will still be bringing over the BEM/atomic bits and other goodies as needed. The intent is to give us a clear slate to build back up.

wylie commented 8 years ago

Could you also remove all of the GruntIcon stuff? I still think that all of that should become a component in Buzz React. Perhaps that is too much for this blank slate PR?

esimons commented 8 years ago

@wylie we're assuming IE9+ with the React stuff now, so Grunticon I don't think needs to even be in the picture.

gjjones commented 8 years ago

@esimons, Some conversation is getting lost with some of it happening in flowdock instead. There's a task for SVGs to be dealt with on this US. It'll be dealt with once this settles. This one is the current inspiration for a new direction.

wylie commented 8 years ago

@esimons, sure, that's awesome. I don't care whether or not we use GruntIcon. I'm just of the mind that SVG's should come out of Edna

wylie commented 8 years ago

@gjjones I'm all good with this PR, but I'm sure I can continue to comment on it…

esimons commented 8 years ago

@wylie @gjjones Gotcha, I misunderstood. 100% on board with components encapsulating icons instead of baking into Edna.

wylie commented 8 years ago

That's right you misunderstood! To the Battle Cube!

esimons commented 8 years ago

soundthehornofbattle