search

ebsco / edna

A custom CSS framework
Other
1 stars 8 forks source link

rename label to option-text to prevent clashing dropdowns and input f… #227

Closed pivnickm closed 8 years ago

pivnickm commented 8 years ago

rename label to option-text to prevent clashing dropdowns and input fields where other fields have labels on them.

leachryanb commented 8 years ago

@pivnickm This being a low-level frameworky thing, are you sure this doesn't kill anything else?

gjjones commented 8 years ago

of course there's the obligatory, don't forget to check the other interfaces and such

pivnickm commented 8 years ago

Everything looks fine in NUP. I think the only other place the dropdown widget it used is the DMP Recent updates.

How much do I need to look at the classic Buzz versions of EFSP and K5? I'm actually not sure if any of that is used anymore.

EAE-BuildUser commented 8 years ago

There is no more Buzz version of those interfaces, so you’re good. Only other would be nurc.

From: Matt Pivnick notifications@github.com<mailto:notifications@github.com> Reply-To: ebsco/edna reply@reply.github.com<mailto:reply@reply.github.com> Date: Friday, September 23, 2016 at 8:04 AM To: ebsco/edna edna@noreply.github.com<mailto:edna@noreply.github.com> Subject: Re: [ebsco/edna] rename label to option-text to prevent clashing dropdowns and input f… (#227)

Everything looks fine in NUP. I think the only other place the dropdown widget it used is the DMP Recent updates.

How much do I need to look at the classic Buzz versions of EFSP and K5? I'm actually not sure if any of that is used anymore.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://github.com/ebsco/edna/pull/227#issuecomment-249174404, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AKiWcMrTjv55h9QrP6PoG-wLbvoTXnWwks5qs8BNgaJpZM4KE24k.