search

ebsco / edsapi-koha-plugin

EBSCO Koha Plugin
https://github.com/ebsco/edsapi-koha-plugin
Apache License 2.0
16 stars 26 forks source link

Newer versions of perl have trouble with require 'eds-methods.pl' with strict on #46

Closed wizzyrea closed 4 years ago

wizzyrea commented 6 years ago

The result is that eds-methods.pl won't load, as . isn't in @inc.

wizzyrea commented 6 years ago

to replicate, you'll probably need Debian 9

Alex-Buckley commented 5 years ago

Hi Liz,

We found this as well on a Debian 9 machine and running Koha 18.11.x branch. We have found adding ./ to the start of the filename in the require line in eds-detail.pl, eds-ac.pl, eds-cite.pl, eds-raw.pl, eds-search.pl, pfi-search.pl fixes this issue so I have submitted a pull request with these fixes in it:

https://github.com/ebsco/edsapi-koha-plugin/pull/67

We also found that the line: $self->go_home(); which was removed in the Koha EDS master branch is required otherwise a 500 error is shown upon saving the Koha EDS configuration page.

Now with this aforementioned fix after saving the config form you are redirected back to the Tools > Tool plugins page in the Koha intranet.

Cheers, Alex

cambw commented 5 years ago

68 should close this issue

mmabrahamson commented 4 years ago

This looks to be resolved with the 19.05 release to master, but please feel free to reopen if you install the new release and still see this issue.