search

ebsco / edsapi-ruby

A Ruby interface to the EBSCO Discovery Services API
MIT License
7 stars 10 forks source link

Misleading text when a search result has no title: This title is unavailable for guests, please login to see more information. #99

Open sandbergja opened 4 years ago

sandbergja commented 4 years ago

I noticed there is already a TODO item in the code: https://github.com/ebsco/edsapi-ruby/blob/1432056a4407b6fdfb6fda8709752d6e38975553/lib/ebsco/eds/record.rb#L279

Our patrons have found this very confusing, especially since it displays whether guest is true or false/the user is logged in or not!

Ideally, there wouldn't be items without titles in the first place. Failing that, it would be helpful to be able to configure this field, with a more sensible default value.

Also noting that the string isn't currently i18n-compatible.

efrierson commented 3 years ago

Do you have an example we could test. Agree, there should be no records without a title when in full-access mode, so I'd like to report the record to our content team. I did follow the search link in the issue report in your fork (a search for centos), but that no-title string doesn't appear in the first couple of pages of results.

Completely aside from the specific missing title problem, I have logged the request for configurability of this string. Thanks!

sandbergja commented 3 years ago

If I remember correctly, I think I was accidentally setting guest=true, even when I thought it was false. So I don't think the records-without-titles issue is actually valid. Apologies for not updating this ticket accordingly!

efrierson commented 3 years ago

No prob - keeping it open to track the configurability of this string.