search

ebsco / openathens-koha-plugin

Offer single-sign on to your users by integrating Koha and OpenAthens. The OpenAthens plugin for Koha creates an OpenAthens user session for anyone that logs into Koha. This allows users to now access publisher resources using their Koha login credentials.
3 stars 7 forks source link

OAKoha.pl does not work with newer Koha vesions (tried 21.11) #11

Closed jotkaka closed 2 years ago

jotkaka commented 2 years ago

Hi!

I'm not sure if the project is still active, but I find it very useful. The version for 17.11.xx worked well for 20.05. Unfortunately not for 21.11. At least two spots are to be corrected in OAKoha.pl -- functions have to be imported explicitly now:

use C4::Auth qw( get_template_and_user );
use C4::Output qw( output_html_with_http_headers );

Also, in line (ca.) 115 eq should be used instead of == (twice).

Janusz

minusdavid commented 2 years ago

I had to look at this just now, and it looks like those function exports are the bare minimum that are needed.

I'm planning to do a pull request for this in about 16 hours.

minusdavid commented 2 years ago

I may have gotten impatient and just did it now:

https://github.com/ebsco/openathens-koha-plugin/pull/12

mkstephens commented 2 years ago

We were just upgraded to 21.11.05 from 21.05 and are now having this issue as well. Please review the pull request and release an updated version of the plugin!

mmabrahamson commented 2 years ago

I've created a new version of the PR so that we can create a 21.11 branch and have an appropriate release created. Can you test the KPZ here and let me know if it's working properly for you? https://github.com/ebsco/openathens-koha-plugin/blob/Koha-21.11.x/oa_plugin_21.1101.kpz. I'm unable to test locally at the moment.

kylemhall commented 2 years ago

@mmabrahamson we are experiencing the same error, and I can verify your patched kpz works!

mmabrahamson commented 2 years ago

Thanks! I'll go ahead and close this issue then. I appreciate the confirmation!