search

ebshimizu / hots-parser

A node-based Heroes of the Storm match parser
MIT License
12 stars 3 forks source link

Getting error -2 #53

Open Ponjimon opened 5 years ago

Ponjimon commented 5 years ago

Latest patch replays, getting error -2

ebshimizu commented 5 years ago

-2's the general failure code. I'll need to take a closer look. Can you send/post a link to a replay that's causing this error? I've been parsing replays from last week without issue.

Ponjimon commented 5 years ago

Will do once I get home from work tomorrow

Ponjimon commented 5 years ago

As promised, here are my latest two replays (both won't work) https://github.com/lookapanda/hots-parser-replay

ebshimizu commented 5 years ago

got them, thanks! will take a look this week

Ponjimon commented 5 years ago

Cool, thanks!

On Mon 16. Sep 2019 at 23:56, Evan Shimizu notifications@github.com wrote:

got them, thanks! will take a look this week

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/ebshimizu/hots-parser/issues/53?email_source=notifications&email_token=AAF4ESEZLBFBTRM3OP2HHQ3QJ76HDA5CNFSM4IW4J2EKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD62UM4Q#issuecomment-531973746, or mute the thread https://github.com/notifications/unsubscribe-auth/AAF4ESBKKC3UNF5DK43JLM3QJ76HDANCNFSM4IW4J2EA .

ebshimizu commented 5 years ago

hm, I'm unable to reproduce any error when parsing these files on my machine. What platform are you running on? I'm running a Windows machine using Node 10 and the latest release of this code (tag 2.47.3)

I have gotten some reports of parsing issues on other platforms in the past involving a dependent module.

Ponjimon commented 5 years ago

I‘m running Windows but using WSL (Ubuntu 18.04)

On Thu 19. Sep 2019 at 20:37, Evan Shimizu notifications@github.com wrote:

hm, I'm unable to reproduce any error when parsing these files on my machine. What platform is this running on? I'm running a Windows machine using Node 10 and the latest release of this code (tag 2.47.3)

I have gotten some reports of parsing issues on other platforms in the past involving a dependent module.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/ebshimizu/hots-parser/issues/53?email_source=notifications&email_token=AAF4ESBOJ3PP7GIWRRW3UHLQKPBHXA5CNFSM4IW4J2EKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD7ENWDI#issuecomment-533256973, or mute the thread https://github.com/notifications/unsubscribe-auth/AAF4ESAFBZ7PJHU6O7BGDIDQKPBHXANCNFSM4IW4J2EA .

ebshimizu commented 5 years ago

hmm yeah you might be running into some issues with the stormreplay module used in heroprotocol. That module uses a native extension to accelerate the replay extraction, but sometimes runs into problems. You can try to disable the native extension or possibly try downgrading heroprotocol to the 1.0 branch in the package manifest and see if it works.

patonz commented 4 years ago

hi @ebshimizu , got same error today with some games played yesterday. Tell me if u have the same issue so we can fix together if u need some help

ebshimizu commented 4 years ago

There have been a few issues with the base heroprotocol repository (https://github.com/Blizzard/heroprotocol/issues/92) and this package had to swap over to a fallback. First try re-installing the hots-parser package, and then let me know if the issue still persists.