ebtc-protocol / ebtc-multisig

eBTC's EVM multisig operations.
GNU Affero General Public License v3.0
0 stars 0 forks source link

Adapt to new release candidate #17

Closed sajanrajdev closed 9 months ago

sajanrajdev commented 10 months ago

Tackles #5

All tests are passing: image

NOTE: There is a RC0.7 coming up. Nevertheless, governance functions won't change from rc0.6 so this setup should be enough for testing purposes. I ran the current setup against the adapted governance wiring script (which will be used with rc0.7 so, unless anything changes on the script after review is completed, rc0.6 should reflect the latest governance implementation.

This can be checked in the following PR.

Proceeded this way since rc0.7 is taking longer than expected and we need to conduct the testnet governance testing.

sajanrajdev commented 9 months ago

New and adapted tests are passing: image

sajanrajdev commented 9 months ago

Thank you for the diligent reviews @rayeaster and @petrovska-petro.

@petrovska-petro, the Primary Oracle (and also the Secondary, really) would only be really swapped out in case of a security concern or commercial blockage and of course governance scrutiny would be required.

With regards to the Active Pool signature, good catch. The removal of the feeRecipientAddress setter will be included on RC0.7. I thought it was better to wait until this final release candidate is deployed to TestNet to generate new interfaces all around. But very good call, issue created for this: https://github.com/ebtc-protocol/ebtc-multisig/issues/23