search

ebtc-protocol / ebtc-multisig

eBTC's EVM multisig operations.
GNU Affero General Public License v3.0
0 stars 0 forks source link

feat: intro univ3 and prep seeding scripting for ebtc/wbtc pool #18

Closed petrovska-petro closed 9 months ago

petrovska-petro commented 10 months ago

tackles #8 

brownie run scripts/univ3_management pool_creation_and_init_seeding
sajanrajdev commented 9 months ago

Tackles https://github.com/ebtc-protocol/ebtc-multisig/issues/11

petrovska-petro commented 9 months ago

great suggestion @sajanrajdev i added tests on the last commits for the actions intended for now

one thing im still researching is something to note on the test_position_creation that the ticks of the position when converting them from the upper and lower ticks does not match the intended. values are a bit off:

price_lower_ticket=0.9891
price_higher_tick=0.995

run: brownie test tests/univ3/* -s

im still investigating if related to tick spacing

petrovska-petro commented 9 months ago

pushed 5241b91ba1edc62997a7f461694bc89c054014c2 which i think was a mistaken assumptions inherit from the fact that badgerwbtc and ethgtc shared the same fee tier, but this one suggested in the forum is meant to be 0.05% which by result the tick spacing will be different. now it should represent a more precise representation of the nft positions created given the price targets. will be great if you could also provide feedback if you see something im missing out @sajanrajdev