ebtc-protocol / ebtc-multisig

eBTC's EVM multisig operations.
GNU Affero General Public License v3.0
0 stars 0 forks source link

Feat/rc07 #29

Closed sajanrajdev closed 4 months ago

sajanrajdev commented 4 months ago

All tests are passing: image

TODO: Add scripts for the new functions and make sure that non of the previous scripts broke.

sajanrajdev commented 4 months ago

Thank you very much for your review @petrovska-petro. The reason for adding stETH's Interface is for when the mainnet contracts are wired. Perhaps we should make the libraries use the interfaces for the collateral and price feed be chosen dynamically based on the chain. I attempted this but, for some reason, the script breaks whenever I try to call chain.id. This is why I haven't used the r instance of the registry. Could you check if it works on your side? I have been digging for a while with no luck.

Comments were addressed, lint was fixed and all tests are passing: image image