Enforcing 1000 wei min change

[dapp-whisperer]

Review Notes (WIP)

• MIN_CHANGE constant
• Introduces constant for new error message rather than inline string (like)

elegantly adapts checks for nonzero values to minimum values

_requireNonZeroDebtChange → _requireMinDebtChange
_requireNonZeroAdjustment → _requireMinAdjustment
_requireNonZeroDebt -> _requireMinDebt

error messages adapt to new reality

Open

• require debt is >1000 units

Adjust

• on debt increase, confirm increase is >1000
• on debt decrease, confirm min debt is >1000 after change
• on coll change, confirm the stEthBalance (not shares) change is >1000 units
  • (min stEthBalance enforced as before)

Test Change Notes

Introduces constants for new error message in fixture

confirms revert w/ correct error message, with 1 wei changes in-line in some existing tests

should confirm that all values <1000 result in revert via fuzz tests when complete

• open
• adjust
• close
• partialLiquidation
• partialRedemption

[dapp-whisperer]

Redemption Spec

Gracefully skip partials when CDP has < MIN_CHANGE debt remaining, similar to min coll check.

[wtj2021]

medusa coverage report https://drive.google.com/file/d/1lSy8wQWgwQK7RlBXSkprNnSGufUmTvVu/view?usp=drive_link