search

ebtc-protocol / ebtc

GNU General Public License v3.0
48 stars 24 forks source link

LSR uint128 invariant failures #765

Closed dapp-whisperer closed 5 months ago

dapp-whisperer commented 5 months ago

Added to EchdinaToFoundry with comment showing which invariant failed

[from @rayeaster ] for L-12 & L_17, they are fixed in another PR https://github.com/ebtc-protocol/ebtc/pull/764/commits/498c7a1b7d605c82bc8f3616aefad70dfe4bc6fb

for L_15, I think we should fix it by only check the after status without combining before & after together since there might be other previous test steps impact the variable lastGracePeriodStartTimestamp as shown in the test test_lrsUint128_failure_0. The proposed fix commit is https://github.com/ebtc-protocol/ebtc/pull/765/commits/9a5c7ca193331456857dccc662b3a7d322415788#diff-18525b035e0d27c42350acd0a3a8545337251874a7b8b4227056f1c20ba58fbaR209

for F_01, compare strictly for shares instead of balance since sometimes the share (e.g., 1 wei) is too small

getrecon-bot commented 5 months ago
Job ID ac66edd8-9f74-47bb-8763-252ed338b4a5
Command yarn && git submodule init && git submodule update && solc-select use 0.8.17 && cd packages/contracts/ && yarn echidna --test-mode assertion --test-limit 600000
Instance ID i-0e81eeb29f82adedf
Instance Type c5.2xlarge
Status Started
Elapsed
getrecon-bot commented 5 months ago
Job ID f389534b-b2ea-450f-98d7-dde4403644d1
Command yarn && git submodule init && git submodule update && solc-select use 0.8.17 && cd packages/contracts/ && yarn echidna --test-mode assertion --test-limit 600000
Instance ID i-0c9dad9bdfde17a97
Instance Type c5.2xlarge
Status Started
Elapsed
getrecon-bot commented 5 months ago
Job ID ac66edd8-9f74-47bb-8763-252ed338b4a5
Command yarn && git submodule init && git submodule update && solc-select use 0.8.17 && cd packages/contracts/ && yarn echidna --test-mode assertion --test-limit 600000
Instance ID i-0e81eeb29f82adedf
Instance Type c5.2xlarge
Status Running
Elapsed 37 seconds
getrecon-bot commented 5 months ago
Job ID ac66edd8-9f74-47bb-8763-252ed338b4a5
Command yarn && git submodule init && git submodule update && solc-select use 0.8.17 && cd packages/contracts/ && yarn echidna --test-mode assertion --test-limit 600000
Instance ID i-0e81eeb29f82adedf
Instance Type c5.2xlarge
Status Running
Elapsed 38 seconds
getrecon-bot commented 5 months ago
Job ID f389534b-b2ea-450f-98d7-dde4403644d1
Command yarn && git submodule init && git submodule update && solc-select use 0.8.17 && cd packages/contracts/ && yarn echidna --test-mode assertion --test-limit 600000
Instance ID i-0c9dad9bdfde17a97
Instance Type c5.2xlarge
Status Running
Elapsed 38 seconds
getrecon-bot commented 5 months ago
Job ID f389534b-b2ea-450f-98d7-dde4403644d1
Command yarn && git submodule init && git submodule update && solc-select use 0.8.17 && cd packages/contracts/ && yarn echidna --test-mode assertion --test-limit 600000
Instance ID i-0c9dad9bdfde17a97
Instance Type c5.2xlarge
Status Running
Elapsed 38 seconds
getrecon-bot commented 5 months ago
Job ID a623d0e9-001b-43aa-be46-f3ecb02e122c
Command yarn && git submodule init && git submodule update && solc-select use 0.8.17 && cd packages/contracts/ && yarn echidna --test-mode assertion --test-limit 600000
Instance ID i-05fdf1683925cbb65
Instance Type c5.2xlarge
Status Started
Elapsed
getrecon-bot commented 5 months ago
Job ID a623d0e9-001b-43aa-be46-f3ecb02e122c
Command yarn && git submodule init && git submodule update && solc-select use 0.8.17 && cd packages/contracts/ && yarn echidna --test-mode assertion --test-limit 600000
Instance ID i-05fdf1683925cbb65
Instance Type c5.2xlarge
Status Running
Elapsed 1 minute 8 seconds
getrecon-bot commented 5 months ago
Job ID a623d0e9-001b-43aa-be46-f3ecb02e122c
Command yarn && git submodule init && git submodule update && solc-select use 0.8.17 && cd packages/contracts/ && yarn echidna --test-mode assertion --test-limit 600000
Instance ID i-05fdf1683925cbb65
Instance Type c5.2xlarge
Status Running
Elapsed 1 minute 9 seconds
getrecon-bot commented 5 months ago
Job ID 2ef1e9c3-a1b1-41b5-a49a-c6bd45e9b977
Command yarn && git submodule init && git submodule update && solc-select use 0.8.17 && cd packages/contracts/ && yarn echidna --test-mode assertion --test-limit 600000
Instance ID i-0dd24969f712a48c6
Instance Type c5.2xlarge
Status Started
Elapsed
getrecon-bot commented 5 months ago
Job ID 2ef1e9c3-a1b1-41b5-a49a-c6bd45e9b977
Command yarn && git submodule init && git submodule update && solc-select use 0.8.17 && cd packages/contracts/ && yarn echidna --test-mode assertion --test-limit 600000
Instance ID i-0dd24969f712a48c6
Instance Type c5.2xlarge
Status Running
Elapsed 42 seconds
getrecon-bot commented 5 months ago
Job ID 2ef1e9c3-a1b1-41b5-a49a-c6bd45e9b977
Command yarn && git submodule init && git submodule update && solc-select use 0.8.17 && cd packages/contracts/ && yarn echidna --test-mode assertion --test-limit 600000
Instance ID i-0dd24969f712a48c6
Instance Type c5.2xlarge
Status Running
Elapsed 43 seconds
getrecon-bot commented 5 months ago
Job ID f389534b-b2ea-450f-98d7-dde4403644d1
Command yarn && git submodule init && git submodule update && solc-select use 0.8.17 && cd packages/contracts/ && yarn echidna --test-mode assertion --test-limit 600000
Instance ID i-0c9dad9bdfde17a97
Instance Type c5.2xlarge
Status Error
Elapsed 1 day 14 hours 50 minutes 44 seconds
getrecon-bot commented 5 months ago
Job ID a623d0e9-001b-43aa-be46-f3ecb02e122c
Command yarn && git submodule init && git submodule update && solc-select use 0.8.17 && cd packages/contracts/ && yarn echidna --test-mode assertion --test-limit 600000
Instance ID i-05fdf1683925cbb65
Instance Type c5.2xlarge
Status Error
Elapsed 1 day 13 hours 9 minutes 28 seconds
getrecon-bot commented 5 months ago
Job ID ac66edd8-9f74-47bb-8763-252ed338b4a5
Command yarn && git submodule init && git submodule update && solc-select use 0.8.17 && cd packages/contracts/ && yarn echidna --test-mode assertion --test-limit 600000
Instance ID i-0e81eeb29f82adedf
Instance Type c5.2xlarge
Status Error
Elapsed 2 days 11 hours 53 minutes 35 seconds
getrecon-bot commented 5 months ago
Job ID 2ef1e9c3-a1b1-41b5-a49a-c6bd45e9b977
Command yarn && git submodule init && git submodule update && solc-select use 0.8.17 && cd packages/contracts/ && yarn echidna --test-mode assertion --test-limit 600000
Instance ID i-0dd24969f712a48c6
Instance Type c5.2xlarge
Status Error
Elapsed 1 day 15 hours 59 minutes 17 seconds