search

ebtc-protocol / ebtc

GNU General Public License v3.0
54 stars 24 forks source link

removing price feed dynamic decimals #769

Closed wtj2021 closed 8 months ago

wtj2021 commented 8 months ago
wtj2021 commented 8 months ago

coverage report from medusa run https://drive.google.com/drive/u/0/folders/1vQtvkthngV7McX18YIKVx35hSRXYAiSF?ths=true

CodingNameKiki commented 8 months ago

Q: Shouldn't we apply the same changes to ChainlinkCaller as well?

wtj2021 commented 8 months ago

Q: Shouldn't we apply the same changes to ChainlinkCaller as well?

Yeah, I think we should apply the same changes to ChainlinkCaller. However, I don't think that contract is being used anywhere. Lemme see if it can be removed...

CodingNameKiki commented 8 months ago

However, I don't think that contract is being used anywhere.

Yeah, l am not sure about that as well tbh but it's good to note.

getrecon-bot commented 8 months ago
Job ID a1eafc58-6d26-40b8-8368-64a720631f7f
Command yarn && git submodule init && git submodule update && solc-select use 0.8.17 && cd packages/contracts/ && yarn echidna --test-mode assertion --test-limit 600000
Instance ID i-02bdedb46ae3e67f0
Instance Type c5.2xlarge
Status Started
Elapsed
getrecon-bot commented 8 months ago
Job ID a1eafc58-6d26-40b8-8368-64a720631f7f
Command yarn && git submodule init && git submodule update && solc-select use 0.8.17 && cd packages/contracts/ && yarn echidna --test-mode assertion --test-limit 600000
Instance ID i-02bdedb46ae3e67f0
Instance Type c5.2xlarge
Status Running
Elapsed 41 seconds
getrecon-bot commented 8 months ago
Job ID a1eafc58-6d26-40b8-8368-64a720631f7f
Command yarn && git submodule init && git submodule update && solc-select use 0.8.17 && cd packages/contracts/ && yarn echidna --test-mode assertion --test-limit 600000
Instance ID i-02bdedb46ae3e67f0
Instance Type c5.2xlarge
Status Running
Elapsed 42 seconds
getrecon-bot commented 8 months ago
Job ID a1eafc58-6d26-40b8-8368-64a720631f7f
Command yarn && git submodule init && git submodule update && solc-select use 0.8.17 && cd packages/contracts/ && yarn echidna --test-mode assertion --test-limit 600000
Instance ID i-02bdedb46ae3e67f0
Instance Type c5.2xlarge
Status Error
Elapsed 1 day 15 hours 17 minutes 11 seconds