search

ebtc-protocol / ebtc

GNU General Public License v3.0
56 stars 25 forks source link

Release 0.7rc2 #781

Closed dapp-whisperer closed 9 months ago

dapp-whisperer commented 9 months ago

Consolidates:

Summary by CodeRabbit

getrecon-bot commented 9 months ago
Job ID 00c190b0-d09c-4ea0-967e-71d53fd348b4
Command yarn && git submodule init && git submodule update && solc-select use 0.8.17 && cd packages/contracts/ && yarn echidna --test-mode assertion --test-limit 600000
Instance ID i-0f05e5acc21a8bc1c
Instance Type c5.2xlarge
Status Started
Elapsed
getrecon-bot commented 9 months ago
Job ID 00c190b0-d09c-4ea0-967e-71d53fd348b4
Command yarn && git submodule init && git submodule update && solc-select use 0.8.17 && cd packages/contracts/ && yarn echidna --test-mode assertion --test-limit 600000
Instance ID i-0f05e5acc21a8bc1c
Instance Type c5.2xlarge
Status Running
Elapsed 42 seconds
getrecon-bot commented 9 months ago
Job ID 00c190b0-d09c-4ea0-967e-71d53fd348b4
Command yarn && git submodule init && git submodule update && solc-select use 0.8.17 && cd packages/contracts/ && yarn echidna --test-mode assertion --test-limit 600000
Instance ID i-0f05e5acc21a8bc1c
Instance Type c5.2xlarge
Status Running
Elapsed 42 seconds
coderabbitai[bot] commented 9 months ago

[!IMPORTANT]

Auto Review Skipped

Review was skipped due to path filters

Files ignored due to path filters (1) * `packages/contracts/foundry.toml` is excluded by: `!**/*.toml`

Walkthrough

The recent updates to the contracts introduce enhancements in debt calculation, TWAP failure handling, and invariant testing. A notable addition is the handling of rounding errors and adjustments in debt and collateral calculations, alongside improved system debt management through castedSystemDebt and TWAP-related modifications. These changes aim to improve the robustness and accuracy of the system's financial operations, ensuring better stability and reliability.

Changes

Files Changes
.github/workflows/invariant-test.yml Short summary
.../contracts/ActivePool.sol, .../contracts/CdpManager.sol, .../contracts/Dependencies/TwapWeightedObserver.sol, .../contracts/Interfaces/ITwapWeightedObserver.sol Enhanced TWAP failure handling, introduced castedSystemDebt, and added twapDisabled functionality.
.../contracts/SyncedLiquidationSequencer.sol Adjusted liquidation logic with _TCR comparison change.
.../contracts/TestContracts/AccruableCdpManager.sol, .../contracts/TestContracts/BaseStorageVariables.sol Added new functions and variables for improved accounting and storage management.
.../contracts/TestContracts/invariants/BeforeAfter.sol, .../contracts/TestContracts/invariants/Properties.sol, .../contracts/TestContracts/invariants/PropertiesDescriptions.sol, .../contracts/TestContracts/invariants/TargetFunctions.sol, .../contracts/TestContracts/invariants/echidna/EchidnaProperties.sol, .../contracts/foundry_test/EchidnaToFoundry.t.sol Enhanced invariant testing with new checks, assertions, and test functions. Updated logic for debt and collateral calculation adjustments.

🐰✨
In the realm of code where contracts intertwine,
A rabbit hopped through, making systems align.
With a flick and a hop, and a twirl of its ear,
It tweaked and it tuned, till the errors did clear.
"To solidity!" it cheered, with a gleeful delight,
For the blockchain was stronger, and ever so bright.
🌟🐇

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with CodeRabbit: - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit-tests for this file.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit tests for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository from git and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit tests.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger a review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - The JSON schema for the configuration file is available [here](https://coderabbit.ai/integrations/coderabbit-overrides.v2.json). - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json` ### CodeRabbit Discord Community Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback.
dapp-whisperer commented 9 months ago

@coderabbitai review

dapp-whisperer commented 9 months ago

Important

Auto Review Skipped

Auto reviews are disabled on base/target branches other than the default branch. Please add the base/target branch pattern to the list of additional branches to be reviewed in the settings.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository.

To trigger a single review, invoke the @coderabbitai review command.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:

    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.

  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:

    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.

  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:

    • @coderabbitai generate interesting stats about this repository from git and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

@coderabbitai review

coderabbitai[bot] commented 9 months ago

@dapp-whisperer, to enable auto reviews for branches other than the default branch, please ensure that the base/target branch pattern is added to the list of additional branches to be reviewed in your repository settings. This can be done by updating the .coderabbit.yaml configuration file in the root of your repository or through the CodeRabbit UI settings.

For detailed guidance on configuring CodeRabbit, including adding additional branches for review, please refer to the CodeRabbit Configuration File documentation. If your editor supports YAML language server, adding the schema path at the top of the .coderabbit.yaml file will enable auto-completion and validation, making the configuration process smoother.

Should you need further assistance or have any questions, feel free to join our Discord Community for support, feature requests, and feedback. Thank you for considering giving CodeRabbit a shout-out on social media; your support helps us grow and offer our services to the OSS community.

getrecon-bot commented 9 months ago
Job ID 00c190b0-d09c-4ea0-967e-71d53fd348b4
Command yarn && git submodule init && git submodule update && solc-select use 0.8.17 && cd packages/contracts/ && yarn echidna --test-mode assertion --test-limit 600000
Instance ID i-0f05e5acc21a8bc1c
Instance Type c5.2xlarge
Status Success
Elapsed 1 day 21 hours 30 minutes 55 seconds