Feat surplus invariant fixed

dapp-whisperer commented 4 months ago

Summary by CodeRabbit

New Features
- Enhanced surplus check logic in contract operations to improve reliability and security.
- Introduced a new test for liquidation scenarios, enhancing test coverage and stability.
Bug Fixes
- Improved assignment logic for transaction initiators in tests, ensuring more accurate simulation of user interactions.
Refactor
- Updated test setup and logging for better clarity and debugging capabilities in testing environments.

coderabbitai[bot] commented 4 months ago

Walkthrough

The recent updates involve enhancing the logic for surplus checks in a smart contract and improving a test suite for better coverage and debugging capabilities. Specifically, the surplus check logic now considers an additional condition, and the testing framework sees refinements in variable assignments and the introduction of new logging and testing functionalities focused on liquidation scenarios.

Changes

Files	Summary
`.../TestContracts/invariants/TargetFunctions.sol`	Updated surplus check logic to include a condition based on `_icrToLiq` compared to `cdpManager.MCR()`.
`.../foundry_test/EchidnaToFoundry.t.sol`	- Added conditional `sender` assignment based on `msg.sender` modulo 3. - Changed `actor` assignment in `setUp`. - Added logging for price variables in `_logStakes`. - Introduced `test_debugTheLiquidation`.

🐇💻✨
In the land of code, where smart contracts thrive,
A rabbit hopped in, making updates come alive.
With a flick and a hop, surplus checks refined,
Tests enhanced, with liquidation in mind.
Through the fields of logic, it dances with grace,
Celebrating changes, in the digital space. 🌟🥕

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)

Tips

### Chat There are 3 ways to chat with CodeRabbit: - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit-tests for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit tests for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit tests.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger a review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - The JSON schema for the configuration file is available [here](https://coderabbit.ai/integrations/coderabbit-overrides.v2.json). - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json` ### CodeRabbit Discord Community Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback.

getrecon-bot commented 4 months ago


Job ID	c4441f51-1a8f-4ade-89ad-e623a99cd4f3
Command	`yarn && git submodule init && git submodule update && solc-select use 0.8.17 && cd packages/contracts/ && yarn echidna --test-mode assertion --test-limit 300000`
Instance ID	`i-017a9636ddeba5622`
Instance Type	`c5.2xlarge`
Status	Started
Elapsed

getrecon-bot commented 4 months ago


Job ID	c4441f51-1a8f-4ade-89ad-e623a99cd4f3
Command	`yarn && git submodule init && git submodule update && solc-select use 0.8.17 && cd packages/contracts/ && yarn echidna --test-mode assertion --test-limit 300000`
Instance ID	`i-017a9636ddeba5622`
Instance Type	`c5.2xlarge`
Status	Running
Elapsed	47 seconds

getrecon-bot commented 4 months ago


Job ID	c4441f51-1a8f-4ade-89ad-e623a99cd4f3
Command	`yarn && git submodule init && git submodule update && solc-select use 0.8.17 && cd packages/contracts/ && yarn echidna --test-mode assertion --test-limit 300000`
Instance ID	`i-017a9636ddeba5622`
Instance Type	`c5.2xlarge`
Status	Running
Elapsed	47 seconds

getrecon-bot commented 4 months ago


Job ID	c4441f51-1a8f-4ade-89ad-e623a99cd4f3
Command	`yarn && git submodule init && git submodule update && solc-select use 0.8.17 && cd packages/contracts/ && yarn echidna --test-mode assertion --test-limit 300000`
Instance ID	`i-017a9636ddeba5622`
Instance Type	`c5.2xlarge`
Status	Error
Elapsed	1 day 5 hours 25 minutes 55 seconds

ebtc-protocol / ebtc