search

ebu / ebu-tt-live-toolkit

Toolkit for supporting the EBU-TT Live specification
http://ebu.github.io/ebu-tt-live-toolkit/
BSD 3-Clause "New" or "Revised" License
25 stars 10 forks source link

Specify incompatible attributes #518

Closed nigelmegitt closed 4 years ago

nigelmegitt commented 4 years ago

Fixes #514.

coveralls commented 4 years ago

Coverage Status

Coverage remained the same at 85.209% when pulling ef49c3b05ffcc63358416720d82b709ea9961ea1 on issue_514_ERR_DOCUMENT_NOT_COMPATIBLE_errors into b598ff74446663b2692c4902e05e92e2a7d7214d on release/2.1.2.

nigelmegitt commented 4 years ago

Thanks @spoeschel , to specify the attribute names I would have to refactor the code also: I want to do the minimum possible to get this minor bug fixed, so I'll go with this for now. If this is a significant issue that you can't tell if the incompatibility is with the sequence identifier or the timebase attribute, please could you raise that as a new issue?

spoeschel commented 4 years ago

I'm sorry; this was a misunderstanding: I agree that the error message is sufficient to support users in further debugging. I just meant that the parameter attr_names should explicitely be specified in the format call, like this:

ERR_DOCUMENT_NOT_COMPATIBLE.format(attr_names='ebuttp:sequenceIdentifier or ttp:timeBase')