search

ebu / ebu-tt-live-toolkit

Toolkit for supporting the EBU-TT Live specification
http://ebu.github.io/ebu-tt-live-toolkit/
BSD 3-Clause "New" or "Revised" License
25 stars 10 forks source link

build: Added Docker build alternative #565

Closed CCMA-Enginyeria closed 8 months ago

CCMA-Enginyeria commented 8 months ago

Hi! We've added an alternative to build/run using Docker and have updated the README.md to reflect this change. If you need more details, please let us know. Thank you!

nigelmegitt commented 8 months ago

Hi, thanks for this. Please could you explain why this is needed?

CCMA-Enginyeria commented 8 months ago

Thank you for your fast reply @nigelmegitt . We believe that Docker could offer us a faster and simpler way to use the toolkit, as there's no need to worry about the OS or any dependencies; you only need to have the Docker runtime installed. (We've tested it on a Windows host.)

nigelmegitt commented 8 months ago

Thanks @CCMA-Enginyeria - and why do you think this is needed in the main repo? I prefer to minimise the external dependencies as much as possible, and it looks as though this is something you could put into your own fork if you want it.

By the way, moving up to Python3.x is highly desirable for the project, and significant work was done in the BBC fork at https://github.com/bbc/ebu-tt-live-toolkit - I mention this in case it makes your build environment easier to manage.

CCMA-Enginyeria commented 8 months ago

Ok, understood. If you prefer not to add more dependencies, it’s better not to merge that PR. If anybody asks you, we’ll have Docker support on our fork: https://github.com/CCMA-Enginyeria/ebu-tt-live-toolkit 😉. We’ll check the BBC fork; it seems they’ve done a great job. Thank you, @nigelmegitt.

nigelmegitt commented 8 months ago

Closing due to lack of motivation for the change. If there's a strong community desire or need for a docker-based build in future I'd be happy to revisit this decision and consider adding docker support.

andreastai commented 8 months ago

Thanks @CCMA-Enginyeria! I think a Docker build is very helpful for the user community, especially because the current version still runs under Python 2.7, which is phased out on most Systems. To have a Docker build was also discussed before.

I would be in favour of adding this to the main repo because it makes the current code usable. This is also a very "thin" code addition.