search

ebu / ebu_adm_renderer

The EBU ADM Renderer, written in Python, is the reference implementation of EBU Tech 3388
https://ear.readthedocs.io
BSD 3-Clause Clear License
79 stars 13 forks source link

feature: add loudnessMetadata attributes and subelements as per BS.2076-1 #20

Closed kickermeister closed 3 years ago

kickermeister commented 3 years ago

This PR should enable loudnessMetadata as defined in ITU-R BS.2076-1 for both audioContents and audioProgrammes. I noticed a discrepancy in BS.2076-1 regarding the spelling of "dialogueLoudness". The figures 16 and 17 spell it "dialogLoudness" whilst the text spells "dialogueLoudness". ITU-R BS.2076-2 uses only "dialogueLoudness". So I oriented at the text rather than the figures. However, I'm not sure that this was the right interpretation since also the ADM guidelines refer to "dialogLoudness"... I hope these additions are in line with the existing implementations and I also hope that the test(s) make sense the way I wrote it. Please let me know if this is not the case.

tomjnixon commented 3 years ago

Hi, sorry for the delay. This looks good.

I spotted that in BS.2076-2 there can be multiple loudnessMetadata elements in audioProgrammes and audioContents. I think it's worth making that change now, so that users of this don't have to change.

kickermeister commented 3 years ago

Apologies for my delay, I didn't notice that notifications were sent to my old IRT mail address. It seems that this PR can be closed since you made some changes in a #25 ?

tomjnixon commented 3 years ago

Hi, yeah that's the idea, assuming you're ok with the changes i made?