search

ebu / ebucoreplus

Maintenance and development of the EBUCorePlus
MIT License
23 stars 6 forks source link

299 refactoring renaming property cluster 01 #326

Closed alexander-schulze closed 1 month ago

alexander-schulze commented 1 month ago

This pull request includes the renaming of ten object properties.

Reviewers

JuergenGrupp commented 1 month ago

I have 3 improvements to this pull request:

1) I think I have spotted an error in our renaming plan of applyTo: applyTo is currently only used here: Rights applyTo Asset. The wording seemed strange at first, because of the plural "apply" instead of "applies". That is why we proposed this change to hasTerritoryIncludes. But the meaning would change with hasTerritoryIncludeand the grammar of applyTo is fully correct and expresses exactly what our intention is. My conclusion: stick with applyTo and do not rename it.

2) There is another class to use applyTo with: PublicationEvent. My conclusion: add the following restriction to the ontology: "Rights applyTo PublicationEvent.

3) This opens up the opportunity to make "applyTo" and "isCoveredBy" inverse properties. My conclusion: add the rule applyTo isInverseOf isCoveredBy

Please comment!

alexander-schulze commented 1 month ago

Yes @JuergenGrupp, I agree. @aro-max do you agree with these changes so I can proceed with making the updates?

alexander-schulze commented 1 month ago

Here are the latest changes made:

  1. Reinitialized the applyTo object property instead of renaming it to hasTerritoryIncludes.
  2. Removed the Rights hasTerritoryIncludes Asset restriction and replaced it with the Rights applyTo Asset restriction.
  3. Added a new restriction: Rights applyTo PublicationEvent.
  4. Added applyTo object property as the inverse of the isCoveredBy object property, which is renamed to hasRights.
alexander-schulze commented 1 month ago

@JuergenGrupp, can you please review the latest changes and merge it?

alexander-schulze commented 1 month ago

Cleaned up mixed-in property values for rdfs:label and dcterms:description from hasRelatedAgent, ensuring only 3 values for supported languages, and removed owl:IrreflexiveProperty from hasRelatedAgent.