feat!: create Ratio and use it for aspectRatio and displayAspectRatio and frameRate

MarcAntoine-Arnaud commented 5 months ago

issue #332

JuergenGrupp commented 5 months ago

Thank you @MarcAntoine-Arnaud ! If the pull request is approved, it needs to be merged to the "dev" branch, not the "main". Please see : https://github.com/ebu/ebucoreplus/wiki/04-Branching-policy-for-main,-dev-and-issue%E2%80%90branches

JuergenGrupp commented 4 months ago

Currently the property displayAspectRatio has the range "ActiveFormatDescriptorCode" (which is a subclass of "Format"). It is probably intended to use the classification scheme "ebu_ActiveFormatDescriptorCodeCS" here, as defined in http://www.ebu.ch/metadata/cs/EBU_cs_p.zip. Please note, this Format Descriptor Code expresses more than only a ratio. I fear we might lose important information if we reduce it to the class "Ratio". I am not sure either about how to handle the property aspectRatio: should we better extend this to also use the "ActiveFormatDescriptorCode", should we change the range to the "Ratio" class or should we leave it as it is?

JuergenGrupp commented 3 weeks ago

Editorial Committee:

we need both properties, one represents the recording format and the other representing the display format, because in rare cases they will be different
but both properties should take the numerator/denominator style value.

Conclusion: we will create a separate issue on that

ebu / ebucoreplus

feat!: create Ratio and use it for aspectRatio and displayAspectRatio and frameRate #336