ebu / libbw64

Broadcast Wave 64 (ITU-R BS.2088) library
https://libbw64.readthedocs.io
Apache License 2.0
28 stars 16 forks source link

SampleRate parameter in bw64 constructor is uint16 #13

Closed smlehbleh closed 4 years ago

smlehbleh commented 4 years ago

Hi, I noticed when writing out 96khz audio data that the samplerate metadata in the .wav file ended up wrong - looks like the culprit is the samplerate parameter being passed into the Bw64Writer constructor as a 16-bit unsigned int. I think in the bw64 helper wrapper function there is the same issue.

https://github.com/IRT-Open-Source/libbw64/blob/3a43f909f7e8f6bef93403816e9b73b8bfa5a133/include/bw64/writer.hpp#L49

benjamin-weiss commented 4 years ago

Thanks for the bug report. Could you have a look at this PR https://github.com/IRT-Open-Source/libbw64/pull/14

smlehbleh commented 4 years ago

PR looks good thanks