ebullient / obsidian-slides-extended

Create markdown-based reveal.js presentations in Obsidian
MIT License
52 stars 3 forks source link

🐛 titles break embeds #10

Open batonac opened 2 months ago

batonac commented 2 months ago

As I've stated in discussions, custom presentations are the biggest reason I use and love this plugin: craft slide decks in separate notes and sequence them together in a note dedicated to the custom presentation.

I found that the absolute path is (currently) required for embeds to work properly, which is fine, but unfortunately the default absolute path links are not working.

To reproduce, turn on absolute paths: image

Then use the default embed slash command to embed other notes with slides into the current note. By default, Obsidian includes a pipe and title in the wikilink, like so:

%% Default, Broken Syntax %%
![[Stacks/Company Intro|Company Intro]]

![[Stacks/Representatives/John Doe|John Doe]]

![[Stacks/Products/Meat Delivery|Meat Delivery]]

Unfortunately, the title breaks the embed for slides extended. The embeds will only work after removing the title:

%% Fixed Syntax %%
![[Stacks/Company Intro]]

![[Stacks/Representatives/John Doe]]

![[Stacks/Products/Meat Delivery]]

This adds a usage hurdle for new users of this functionality. It would be great to support titled embeds as well as untitled. Perhaps non-absolute link support should be explored as well.

ebullient commented 2 months ago

There is a lot of really weird link parsing in this codebase... some really weird assumptions about how wikilinks work. I haven't used embedding much, but I wonder if absolute paths with markdown links would "just work". I suppose I'll have to add some tests for that, too.

batonac commented 2 months ago

Confirming that markdown-link-based embeds are not supported with the current codebase. Slides Extended simply renders a broken image link: image

ebullient commented 2 months ago

Very helpful! Thank you for checking (and for all of your other examples, too).

batonac commented 2 months ago

On the contrary, thank you for keeping this project alive and moving forward.