🐛 error on copying remote images - Githubissues

ebullient / ttrpg-convert-cli

Utility to convert JSON data (for content you own) from 5etools or pf2etools into Obsidian-friendly Markdown.

https://www.ebullient.dev/projects/ttrpg-convert-cli/

Apache License 2.0

174 stars 37 forks source link

🐛 error on copying remote images #373

Closed TheDSeraph closed 5 months ago

TheDSeraph commented 5 months ago

[ :octagonal_sign: ERR] Unable to copy remote image from https://raw.githubusercontent.com/5etools-mirror-2/5etools-img/main/bestiary/ToA/Mwaxanaré.webp to compendium\5e\bestiary\npc\img\mwaxanare.webp (java.io.IOException: Server returned HTTP response code: 400 for URL: https://raw.githubusercontent.com/5etools-mirror-2/5etools-img/main/bestiary/ToA/Mwaxanaré.webp)

Same error for Ogrémoch from PotA. Error might be caused by the accented é in the name.

Image should have copied

Server returned HTTP response code: 400 and image was not copied

Configuration

OS: Windows
CLI version: 2.3.3
CLI type: exe

Sources:

enabled sources: PotA, ToA
custom templates (attach if possible):

ebullient commented 5 months ago

One thing: this should probably be fixed in the 5eTools source. I can't arbitrarily encode image URLs.. because about half of them are already encoded, which means trying to catch the stragglers that leak through.