search

ebullient / ttrpg-convert-cli

Utility to convert JSON data (for content you own) from 5etools or pf2etools into Obsidian-friendly Markdown.
https://www.ebullient.dev/projects/ttrpg-convert-cli/
Apache License 2.0
152 stars 35 forks source link

specific Homebrew images not linking with notes. #431

Closed DaniSmol closed 2 months ago

DaniSmol commented 3 months ago

Certain Homebrew images &/or tokens are not linked with their corresponding notes. The notes themselves are being generated properly.

Notes are generated without images.

Configuration

Sources:

Note- I am wondering if its possible that the Json for ToB and ToB2 image sources (URL) are the issue. ToB3 has simple spaces in the names for links where ToB and ToB2 use the %20 spacing. The ToB3 creatures are linking properly while 1 and 2 are not. Also I'd like to note that ToB3 does not have a Width and Height statistic under image URLs where ToB1 and 2 do.

Runtime Command - ttrpg-convert.exe --index -o ToB_Test -c ConfigToB.json 5etools-mirror-2.github.io/data

Note - The config files directories are set for my system so don't forget to change them if needed.

ttrpg-convert_ToB.out.txt.txt Kobold Press; Tome of Beasts 2.json Kobold Press; Tome of Beasts 3.json Kobold Press; Tome of Beasts.json ConfigToB.json

ebullient commented 2 months ago

I think this has been fixed.. 🤞 Can you try again with .12 at a minimum?

DaniSmol commented 2 months ago

Unfortunately Im not seeing a difference. Same behavior. I used the latest .12 version. Same config and settings. I used the 2.3.12 examples as well just to be sure it wasn't updated in them. ttrpg-convert.4.29.2024.out.txt.txt Heres the latest Config.

Still has oddly enough the same behavior with many homebrew working including ToB3 but not ToB 1 or 2.

ebullient commented 2 months ago

tob1 & tob2 don't use the same / consistent image urls (perhaps an older format). They aren't getting read. Give me a bit