ebullient / ttrpg-convert-cli

Utility to convert JSON data (for content you own) from 5etools or pf2etools into Obsidian-friendly Markdown.
https://www.ebullient.dev/projects/ttrpg-convert-cli/
Apache License 2.0
149 stars 33 forks source link

Fix some spell and defenses bugs, and refactor away Pf2eTypeReader #464

Closed miscoined closed 1 month ago

miscoined commented 1 month ago

This is mostly refactoring. I've added a Pf2eJsonNodeReader which extends JsonNodeReader with PF2e specific helper methods. This is mostly to be able to use the fluid helper method syntax for common qute object construction. After that, there were several methods in Pf2eTypeReader which seemed like good candidates for moving into Pf2eJsonNodeReader. When I was finished, Pf2eTypeReader was basically empty, so I've removed it and replaced the lingering usages with JsonSource.

Along the way I've fixed some bugs and rendering issues with weaknesses and resistances, and finished implementing the partially-completed spell component support, as well as fixed some other bugs here and there and added some rich data objects for a few things.

The non-refactoring changes are, broadly: