search

ebullient / ttrpg-convert-cli

Utility to convert JSON data (for content you own) from 5etools or pf2etools into Obsidian-friendly Markdown.
https://www.ebullient.dev/projects/ttrpg-convert-cli/
Apache License 2.0
202 stars 41 forks source link

5.24 support #574

Open teunvdingenen opened 1 week ago

teunvdingenen commented 1 week ago

I got most the changes down to generate 5.24 content. If possible it would be nice to get some people to use this code so I can get more feedback on things that are working and are not. There isn't much more I can do at the moment.

There is one remaining problem right now and that is that the cli is generating identical pages for summoned creatures. For example "undead spirit" is getting 7 entires that are the same. I'm not sure if this is a bug or not but either way I can't figure out how to resolve.

Also there seems to have been a change in how features or monsters are being categorized. The effect is that variants aren't correctly being found. I think it's best to wait for future releases of dmg and mm before making big changes. For now it does seem to generate all content you would want.

ebullient commented 1 week ago

Those 7 entries should not be identical. I'll double check. There should be one per spell level with most of the math already done. (I prefer this when adding creatures to encounters, for example).

I have been pulling in some of your changes, but I have more coming. So .. this will be taken as (very welcome!) advice. ;)

ebullient commented 1 week ago

As for the bit about PHB being the default: PHB is still the default for link/reference resolution. XPHB is present and used explicitly in cross-references. I have other changes pending that remove all empty segments to make this explicit and avoid conflicts.

You end up relying on aliasing as a result of reprints to get the right one, which does work, now that I've fixed aliasing. I'll add some tests for XPHB/XDMG only, of course..

teunvdingenen commented 1 week ago

Let me know if there is anything else I can do, I hope these commits are useful.

ebullient commented 6 days ago

They are!!