search

ec- / Quake3e

Improved Quake III Arena engine
GNU General Public License v2.0
1.15k stars 148 forks source link

app will search for pk3 inside and next to the app bundle #245

Closed Bishop-333 closed 8 months ago

Bishop-333 commented 9 months ago

I updated the icon as well because of a demand of a another mac user and its more original than the previous who was the same as ioquake3

Bishop-333 commented 9 months ago

I'll try to correct the build on windows machine and explain more precisely what ive done

Bishop-333 commented 9 months ago

So instead of making the apple executable looking into the hidden directory named .q3a it will look at 3 differents locations : Library/Application Support/Quake3/baseq3 or baseq3 next to the executable or baseq3 inside the .app. Apple users are not really used to hidden folders so no more .q3a created on macs. I look at the makefile and it should not impact any windows machine since unix things are not compiled if im right. For the unix machine it will not change anything too normally. It's just backporting the thing who work for me from ioquake3.

Bishop-333 commented 8 months ago

@ec- I think it's ready to merge

ec- commented 8 months ago

Please group all apple-related code in smaller file count (unix_main.c only for example) and do not declare apple-specific function prototypes in qcommon.h if it is never used on other platforms

Bishop-333 commented 8 months ago

Please group all apple-related code in smaller file count (unix_main.c only for example) and do not declare apple-specific function prototypes in qcommon.h if it is never used on other platforms

I'll try to do that but isnt it necessary to have functions defined in qcommon.h to have files.c and unix_main connected with the same functions ? Maybe I'm wrong

ec- commented 8 months ago

I'll try to do that but isnt it necessary to have functions defined in qcommon.h to have files.c and unix_main connected with the same functions ? Maybe I'm wrong

How does Sys_SetDefaultBasePath() and Sys_Dirname() related to that?

Bishop-333 commented 8 months ago

I'll try to do that but isnt it necessary to have functions defined in qcommon.h to have files.c and unix_main connected with the same functions ? Maybe I'm wrong

How does Sys_SetDefaultBasePath() and Sys_Dirname() related to that?

You right for theses two they are useless, i'll remove them from qcommon.h. but you talked about the apple specific function like Sys_DefaultAppPath who is expressed only for apple machine can I let it in qcommon.h ?

ec- commented 8 months ago

Sys_DefaultAppPath

sure it is ok to declare necessary function that it actually used in files.c but dirname/etc. could be isolated in unix*.c and not exported anywhere - that's my point, just alter minimal set of files/lines needed