ec- / Quake3e

Improved Quake III Arena engine
GNU General Public License v2.0
1.19k stars 154 forks source link

New Cbuf_Add function doesn't play nice with wait command #270

Closed hzurt closed 6 months ago

hzurt commented 7 months ago

Since the commit: 5ca022a4dcc155b1d626a76260a43e37f5b08d4e

The following does not work anymore:

]\set lmao "wait 10; echo aaaaaaaaaaaaaaaaaaaa"
]\vstr lmao 
aaaaaaaaaaaaaa-button13
Unknown command: aaaaaa

The command gets split in two and an unrelated command is inserted as you can see. I don't know where the "-button13" part comes from. I'm running Urban Terror.

What was the problem that this commit intended to solve?

ensiform commented 7 months ago

Presumably a button command you press is being released at that moment

ec- commented 6 months ago

Can't reproduce on windows (native & SDL2 backends):

]\set lmao "wait 10; echo aaaaaaaaaaaaaaaaaaaa"
]\vstr lmao
aaaaaaaaaaaaaaaaaaaa
hzurt commented 6 months ago

I'm on Linux using SDL2 backend (native doesn't work on wayland as far as I can tell). It doesn't happen in the main menu, only when in game.

ec- commented 6 months ago

It doesn't happen in the main menu, only when in game.

confirmed

ec- commented 6 months ago

@hzurt Please check latest build

hzurt commented 6 months ago

works, thanks