search

ec-doris / EuKnowledgeGraph

This repository contains the Wikibase configuration of the EU Knowledge Graph
https://linkedopendata.eu
12 stars 1 forks source link

Is security expose in readme #76

Closed D063520 closed 2 years ago

D063520 commented 2 years ago

@raphdom for me it looks like that there are credentials in the Readme to push images. Can you check if this is the case ....

raphdom commented 2 years ago

not at all, the aws credentials reside in your config file ~/.aws/.credentials, the commands on README has only the path to the ECR image and when you are doing login you are generating a token with your credentials before use it to do a login in the AWS Registry