ec-doris / kohesio-backend

APIs serving Kohesio's frontend
https://kohesio.ec.europa.eu
6 stars 2 forks source link

Allow multiple programmes and budgets for one project #166

Closed madewild closed 2 years ago

madewild commented 2 years ago

Change values to lists in project API Caution, the order will be important since we need to correlate the programme with the budget!

D063520 commented 2 years ago

@roberto-musmeci: we would prefer to discuss with you

DiaZork commented 2 years ago

Some example for this issues (from Bulgaria there is 66 of them):

https://linkedopendata.eu/wiki/Item:Q3884990 https://linkedopendata.eu/wiki/Item:Q3884860

D063520 commented 2 years ago

I would put the budget per program as a reefied statement on the program. Like:

projects -> program -> programX budgets -> budgetProgramX

like this we have the information, if we want we can render it. The only problem is that if we aggregate the budget by program we will take the whole budget of the project for bot programs. @roberto-musmeci: is this a problem?

roberto-musmeci commented 2 years ago

@D063520 I think it's fine to 1) display the aggregate budget across the programs 2) mention the list of programs in the relevant field

madewild commented 2 years ago

Let's add the programmes first and postpone the budget aggregation issue

madewild commented 2 years ago

@raphdom to adapt in the frontend @madewild to check in the exports, pipe separated values?

madewild commented 2 years ago

Already the case in export:

    (GROUP_CONCAT(DISTINCT ?programLabel; SEPARATOR = "|") AS ?Programme_Name)
DiaZork commented 2 years ago

It's done in the backend. You have now a list program that contain the list of the program with 3 attributes which are the same as previously:

If you want to see

raphdom commented 2 years ago

There is no programmingPeriodLabel anymore? Or this is per programme? Can you add this? What is the max number of programmes that one project can have?

roberto-musmeci commented 2 years ago

There is not a maximum of programs but resonably I do not expect more than 4 programs.

On Wed, 21 Sep 2022, 14:47 Raphael Domingues, @.***> wrote:

There is no programmingPeriodLabel anymore? Or this is per programme? Can you add this? What is the max number of programmes that one project can have?

— Reply to this email directly, view it on GitHub https://github.com/ec-doris/kohesio-backend/issues/166#issuecomment-1253661754, or unsubscribe https://github.com/notifications/unsubscribe-auth/AUVD7JM53CGUBPCRHSLJKHLV7L7W7ANCNFSM5XMU6FIA . You are receiving this because you were mentioned.Message ID: @.***>

DiaZork commented 2 years ago

There is no programmingPeriodLabel anymore? Or this is per programme? Can you add this? What is the max number of programmes that one project can have?

I've added it, it was hard coded so i've done the same

raphdom commented 2 years ago

I have put in another box, tell me if you have another suggestion:

Screenshot 2022-09-22 at 08 55 34

https://kohesio.development.ec.europa.eu/en/projects/Q3884990

madewild commented 2 years ago

@roberto-musmeci what do you think?

roberto-musmeci commented 2 years ago

I think you solution is good @raphdom. We can close this.