search

ec-europa / ec_europa

EC Europa theme based on Atomium.
European Union Public License 1.1
4 stars 8 forks source link

CSS class issue inside the EC-Europa theme #53

Open amd-miri opened 6 years ago

amd-miri commented 6 years ago

Hi, Please find the description of the CSS class problem we have with the ApacheSolr Search pages :

Problem : The main content overlap the sidebar column and because of that, we can not change any faceted search filter.

Example : We have an example on our playground : https://webgate.ec.europa.eu/playground-multisite/know4pol/search/site_en

Solution : Please change the classes in the following lines :

  1. <aside class="col-md-3" role="complementary"> should be <aside class="ecl-md-3" role="complementary">
  2. And the parent DIV class should be this one <div class="ecl-row"> , instead of <div class="row">

Thanks a lot for your help, Ahmad

drupol commented 6 years ago

@amd-miri Could you please provide a PR or indicate which files needs to be updated ?

amd-miri commented 6 years ago

Hi @drupol,

I would love to contribute and provide a PR, but I'm not sure which code to change as I don't master these codes very well. I could only debug the issue on the generated search page.

The only related thing that I found is in the Atomimum theme, in these files. I can change them, but I don't know all the side effects of my changes : atomium-7.x-2.x/atomium_bootstrap/templates/region/region.component.inc (for class="col-md-3") atomium-7.x-2.x/atomium_foundation/templates/page/page.tpl.php (for <div class="row">)

Please le me know what are your suggestions, Thanks, Ahmad

drupol commented 6 years ago

Hi,

atomium_bootstrap and atomium_foundation are examples themes. Are you using one of these as base theme ?

amd-miri commented 6 years ago

Hi @drupol, Oops, you're right, I use the main Atomium one as base theme, the references that gave are not even related. Please ignore them.

drupol commented 6 years ago

Ok, but we need to know where is the file to update.

Enable the theme debug mode (in admin/appearance/settings/[your_theme]) and then, check the source code of the page where you have the issue.

From there, you'll find which template is causing the issue, then you let us know and we'll update it accordingly.

Thanks!

drupol commented 6 years ago

Upgrading to version 0.0.8 of ec_europa theme should fix the issue, could you confirm ?