ec-europa / oe-poetry-client

Client library for the European Commission Poetry Service
European Union Public License 1.2
3 stars 2 forks source link

Change Secretariat property #54

Closed ademarco closed 6 years ago

jfhovinne commented 7 years ago

It should be translated to "secretary".

ademarco commented 6 years ago

We discussed with @netlooker and we found out that the French term is only on the Drupal site:

+  private function getContact(array $settings) {
 +    return array(
 +      array(
 +        'type' => 'auteur',
 +        'nickname' => $settings['contacts']['author'],
 +      ),
 +      array(
 +        'type' => 'secretaire',
 +        'nickname' => $settings['contacts']['secretaire'],
 +      ),
 +      array(
 +        'type' => 'contact',
 +        'nickname' => $settings['contacts']['secretaire'],
 +      ),
 +      array(
 +        'type' => 'responsable',
 +        'nickname' => $settings['contacts']['responsible'],
 +      ),
 +    );
 +  }

the type is what Poetry expects, so those are the correct values. @netlooker will just rename keys of $settings['contacts'] array to be in English.

netlooker commented 6 years ago

👍