Code review

[amoeba]

(I'll edit this issue as I go, we can break this into separate issues as needed later).

Stuff that needs changing:

• [x] Change instances of lod.dataone.org to dataone.org
• [ ] URLEncode URIs when appropriate. e.g., dataone.org/datasets/urn:uuid:xyz -> dataone.org/datasets/urn%3Auuid%3Axyz

Stuff that'd be nice to fix/improve:

• [ ] Factor out all API URLs into a global, overridable value
• [ ] Better defaults for host/ports (i.e., Graph())
• [ ] Make all log statements only print on one line
• [x] In-code SPARQL queries should be easier to edit. Right now they have lots of \ns and \ts and other junk.
• [ ] Usages of RDF.Model() should use a context so they always get disposed of properly

[rushirajnenuji]

Hey @amoeba -

Make all log statements only print on one line

Does this apply to only queries or pretty much all the log statements? It might affect the readability of logs but we should be able to use regex if needed while debugging the logs.

[amoeba]

Hey @rushirajnenuji: The way I think about it, it'd affect all logs. It's a low priority thing for getting the service back and turned on so we may not need to do this. It does make visually scanning the logs less easy so it's not a win-win.